Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Fields: Improve how long input (messages) is shown in order details #4547

Closed
birkjernstrom opened this issue Nov 26, 2024 · 5 comments
Labels
contributor friendly Good entry point for potential new contributors enhancement Enhancement of existing features and services ui Changes to our UI alone, i.e no backend changes needed

Comments

@birkjernstrom
Copy link
Member

Description

Easy to miss the entire content of long strings in custom fields on order details.

Current Behavior

Long messages/strings in custom fields are cut in the order details – requiring hover to show the full contents.

Expected Behavior

Experiment with the more user friendly option & design:

  1. Truncate string after X characters followed by ... (Show more)
  2. Show in <textarea disabled> with a somewhat decent default size, but ability to scroll within textarea

Screenshots

image

@birkjernstrom birkjernstrom added enhancement Enhancement of existing features and services contributor friendly Good entry point for potential new contributors ui Changes to our UI alone, i.e no backend changes needed labels Nov 26, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Nov 26, 2024
@plugisto
Copy link

Just an idea: when this is customer facing you should also remove the label "Custom Fields". I believe it's confusing (or just not relevant in the best case). "Custom Fields" as a label is of no interest for them - they don't care how things are called inside of Polar. IMHO you should just remove it. Keep the single label value and that's fine. Nothing else needed.

@frankie567
Copy link
Member

To my defence, this was designed to be displayed in the table, not in a modal with plenty of space 😅

@birkjernstrom
Copy link
Member Author

Just an idea: when this is customer facing you should also remove the label "Custom Fields". I believe it's confusing (or just not relevant in the best case). "Custom Fields" as a label is of no interest for them - they don't care how things are called inside of Polar. IMHO you should just remove it. Keep the single label value and that's fine. Nothing else needed.

Just to clarify the screenshot is from the dashboard and what the developer/seller sees and not the end customer. They only see the field on checkout as an input like the others.

I still hear you though, but I think it's less obvious to not distinguish them since the feature is Custom Fields that the developer can setup themselves. That said, they'll recognize that and perhaps we can distinguish it more with an icon / link to edit the custom field or equivalent vs. the title.

@magarpratik
Copy link
Contributor

Hi @birkjernstrom, it seems the described functionality is already implemented - unless I'm misunderstanding the issue?

Screen.Recording.2024-12-07.at.22.53.56.mov

The dummy data used in the above recording can be found in this commit.

@birkjernstrom birkjernstrom moved this from Backlog to Upcoming in Backlog Dec 8, 2024
@frankie567
Copy link
Member

Definitely fixed 👍

@github-project-automation github-project-automation bot moved this from Upcoming to Done in Backlog Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Done in Polar Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor friendly Good entry point for potential new contributors enhancement Enhancement of existing features and services ui Changes to our UI alone, i.e no backend changes needed
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants