Add transaction timeout #1242
Open
Add transaction timeout #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a transaction timeout global setting to pgbouncer. In the current state there is an idle_in_transaction_timeout and a query_timeout but no transaction_timeout. This is meant to combat issues where a user starts a transaction and then proceeds to wait and issue
SELECT 1;repeatedly thus making the transaction not idle. There is an equivalent setting on the postgres side but it is easily overridden by any user.Not looking to get this in before the next release but I believe that this functionality could be very useful and just want to put a PR out here for visibility.