-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
direct: Migrate legacy DConfig usage to modern configuration interface #1333
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1333 /- ##
==========================================
Coverage 16.09% 16.18% 0.09%
==========================================
Files 3739 3739
Lines 363643 363741 98
==========================================
Hits 58518 58883 365
Misses 305125 304858 -267
Continue to review full report at Codecov.
|
52d11ca
to
ffd3839
Compare
What's wrong with using the new Pythonic .value property as opposed to the getter method? |
It's used inconsistently. Some code in |
I see no advantage of using Not sure what you mean by "doesn't imply that it can be assigned". It doesn't imply such a thing (read-only properties are common), but it can be assigned, if you wanted to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave existing ConfigVariable* getValue(), setValue(), and value calls alone for this PR to reduce clutter (the style update can go in a new PR). For new code, I prefer using the property over the methods.
Issue description
Some modules in
direct
are still using the old DConfig interface (config.GetBool and friends). They should be migrated to the new ConfigVariableBool (and friends) interface.Solution description
This PR consists of three commits:
value
property accesses to thegetValue()
method calltemp-hpr-fix
setting, which is no longer used, from the contributed sceneeditor moduleconfig.Get*
calls withConfigVariable*
usagesChecklist
I have done my best to ensure that…