TRUNK-6220: When setting the session locale from the user's default locale property, the default locale should be validated #4560
Conversation
| catch (Exception t) { | ||
| log.warn("Unable to parse default locale global property value: " locale, t); | ||
| } | ||
| if (StringUtils.hasLength(locale) && isValid(fromSpecification(locale))) { |
There was a problem hiding this comment.
This shouldn't require two calls to fromSpecification(). However, this PR is also not dealing with the issue in the ticket, which is about the user's default locale property, not the property from the global property. The change here is unnecessary because we validate the global property when setting it.
…ocale property, the default locale should be validated
…ocale property, the default locale should be validated
IamMujuziMoses
force-pushed
the
TRUNK-6220
branch
from
d650286
to
dd30f57
Compare
|
@ibacher I have made some changes based on the earlier review |
|
tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) |
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6220
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master