-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty test class doesn't show warning, but breaks CI by passing on non-zero STDERR from PHPUnit #293
Comments
This also affects downstream test packages like Dusk. |
This also affects the |
Hi there, Do we have any updates on the plans for a fix? Additionally, I'm curious about the status of merging/releasing #294. Could someone also explain why this warning was initially hidden/suppresed? Thanks! |
Bump 👀 |
If there are no tests in a test class file, PHPUnit raises a warning (
Event\Facade::emitter()->testRunnerTriggeredWarning()
- 'no tests found in class') and will pass on a non-zero value toSTDERR
. Collision will not display this warning, but does pass on theSTDERR
value, which led to some confusion when it appeared that all tests were passing, but our CI pipeline was stopping at the test step in failure. However, narrowing it down to this issue took a while as at first I thought it was a bug in the CI runner.You can recreate this with a default Laravel install:
It's not clear to me if this is limited to this one 'empty class' issue, or if all
testRunnerTriggeredWarning
events are ignored.The text was updated successfully, but these errors were encountered: