quic: fixup errant LocalVector usage #56564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
added
author ready
anonrig
reviewed
Jan 11, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Yagiz Nizipli <[email protected]>
anonrig
approved these changes
Jan 12, 2025
jasnell
added
commit-queue-squash
tniessen
approved these changes
Jan 13, 2025
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56564 ✔ Done loading data for nodejs/node/pull/56564 ----------------------------------- PR info ------------------------------------ Title quic: fixup errant LocalVector usage (#56564) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:jasnell/fixup-errant-localvector -> nodejs:main Labels c++, author ready, needs-ci, quic, commit-queue-squash Commits 2 - quic: fixup errant LocalVector usage - Update src/quic/session.cc Committers 2 - James M Snell <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 11 Jan 2025 21:18:46 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56564#pullrequestreview-2545453992 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/56564#pullrequestreview-2546392746 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-11T21:20:06Z: https://ci.nodejs.org/job/node-test-pull-request/64451/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - Update src/quic/session.cc - Querying data for job/node-test-pull-request/64451/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12756293802 |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
removed
commit-queue-squash
jasnell
added a commit
that referenced
this pull request
Jan 14, 2025
PR-URL: #56564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in 7b60bcb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.