Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is nicotine able to discard repeated results in the wishlist like soulseek does for years now? #3170

Open
yataghan012 opened this issue Oct 27, 2024 · 8 comments
Milestone

Comments

@yataghan012
Copy link

Add a "discard repeated results" to each wishlist result.

Is this a current doable feature or is it planned?

@slook
Copy link
Member

slook commented Oct 27, 2024

It is planned see discussion #1604

@yataghan012
Copy link
Author

It is planned see discussion #1604

Why is it taking so long? this discussion is 3 years old already, and soulseekqt has had this feature since at least 2013. I still use soulseekqt solely because of this, even though I use the 2018 appimage.

@slook
Copy link
Member

slook commented Oct 27, 2024

There have been higher priorities.

@mathiascode
Copy link
Member

And all work is done by 1-2 people in their free time, without compensation, so it's simply impossible to prioritize and implement every feature request. I personally try to find a balance between frequent requests and features that are interesting/motivating to implement.

@yataghan012
Copy link
Author

And all work is done by 1-2 people in their free time, without compensation, so it's simply impossible to prioritize and implement every feature request. I personally try to find a balance between frequent requests and features that are interesting/motivating to implement.

Ok I understand. I'll donate when I can and remind you about it, on most aspects I find Nicotine better than SoulseekQt (this one crashers a lot and takes up too much ram), so good job.

@mathiascode
Copy link
Member

I suppose a short-term change we could make is store previously seen wishlist results per session. You would see the same files again after restarting, since seen results are only stored in memory, but at least the endless redundant wishlist tabs during a long session would stop. Would this help in your case?

@slook
Copy link
Member

slook commented Nov 4, 2024

In any case, implementing the discarding of repeated results in at least a basic form would help to start mapping out a development path leading to the full wishlist overhaul, with persistent filtering and everything else, at a later stage.

@yataghan012
Copy link
Author

In any case, implementing the discarding of repeated results in at least a basic form would help to start mapping out a development path leading to the full wishlist overhaul, with persistent filtering and everything else, at a later stage.

In my particular case it would help if you're aiming at a full wishlist update, I appreciate the thought but wishlist per session doesn't make much of a difference. Some of these wishlist items I've had for years.

@mathiascode mathiascode added this to the 3.4.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants