-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set final destination folder upon completion of download, instead of when download is requested - or - allow user to change to download folder for existing/pending downloads #3026
Comments
I'm leaning towards the second option. I don't think this is something you would have to do often, and you risk silently splitting folder downloads into multiple locations if you set the final path later. I don't know what the ideal design for changing the download path would be, but it should be possible to change download paths in bulk without too much effort. |
As a temporary measure, you should be able to open the |
Thanks for the workaround! |
Oops, I thanked you before I actually edited the file... which I can't seem to find. Where is downloads.json located? I thought it would be in ~/.config/Nicotine/, but it was not. When I did a search of my hard drive, only download.json file I found was in ~/Music/Nicotine/lib/pynicotine/tests/unit/transfers, where ~/Music/Nicotine/ is set as my downloads folder, and all that file contained was this:
However, I have dozens (if not hundreds) of files that are waiting to be downloaded. Also, "user1" through "user17" and "song1" through "song17" were what was literally in the file (i.e., I did not substitute those names to mask actual user and song names). |
Your user data is located in somewhere like
What you have found there is dummy data that's used for the CI tests (Continuous Integrations) that are used by developers during build-time for verifying the program works properly. It's a part of the source code package in the repo: nicotine-plus/pynicotine/tests/unit/transfers/downloads.json Lines 1 to 19 in e7c7377
There is no good reason why the Nicotine source code files are saved in your shares, you must have copied it in there yourself by mistake. The source code is not needed for run-time (unless you want to run from source, of course), so it can be deleted. |
D'oh! I thought I had looked in there, thanks.
Yeah, I was experimenting with installing it on a Windows VM, and I can't imagine how or why I would have copied that folder in there, but I have deleted it now. |
It's likely because you chose your Music shares folder to be easily accessible from your VM, so it would have made sense to put things in there during installation. That is a somewhat related reason as to why I am in support of your feature request, because migrating N onto another machine almost always results in different paths being needed, and it is annoying that the Incomplete items break in such cases. |
Describe the solution you'd like
Either:
Ideally both, but if I had to choose one, it would be the first one because then if I change the download location in Settings, I won't have to manually change the download destinations in all the previously initiated downloads.
Additional context
Reason for request: The drive of my original download folder no longer had space for downloads, so I changed the download folder to a larger drive (and took the original external drive offline). However, downloads that were started before the change are still set to go to the old download location, and the destination path cannot be changed. So now, if a song with the old download destination completes, it just stays in the incomplete folder (on my internal drive). I can change the name and manually move it to the intended destination, or remove and re-download the affected songs, but either choice is far from ideal.
The text was updated successfully, but these errors were encountered: