Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/clear #3018

Open
Specchiriflessi opened this issue May 25, 2024 · 5 comments
Open

Remove/clear #3018

Specchiriflessi opened this issue May 25, 2024 · 5 comments

Comments

@Specchiriflessi
Copy link

I've just downloaded the newest version, why does the right-click menu now have Remove where there was Clear? I see that there is now a Clear All submenu, but Clear is the verbiage that is used all throughout the program for that functionality, why make that confusing by changing an instance of the same functionality as Clear to Remove? Remove should be reverted to Clear, I don't see a reason why a user would confuse it with Clear All when that is not what they intend to do.

@slook
Copy link
Member

slook commented May 25, 2024

Thank you for your feedback :)

why does the right-click menu now have Remove where there was Clear?

This string change was made in PR #2923 because of a discussion related to open issue #2922 which is about some measure to help avoid accidental deletion of the history.

The renaming of these button and menu item labels seem to be an interim measure, in part to gather feedback such as you have kindly provided.

@hboetes I'm not sure if the string change on these button and menu item labels were considered to make more sense for non-English translations, or if it was better the way it was before?

@hboetes
Copy link
Member

hboetes commented May 25, 2024

I think remove is clearer. 😎
I just tested a few translations, and "remove" was unambiguous. Clear went all over the place. (transparent/clean)

@mathiascode
Copy link
Member

The meanings I commonly associate with these words:

  • Clear: remove everything
  • Remove: get rid of specific items

The string was changed to Remove to match all other lists in the application (e.g. wishlist, shares), and hopefully provide some more contrast between removing specific items and clearing everything.

What's the first thing that comes to mind when others hear these words?

@hboetes
Copy link
Member

hboetes commented Jun 3, 2024

I agree, that's how I'd interpret them in the given context.

@Specchiriflessi
Copy link
Author

If that's what is commonly associated with clear there would be no need for Clear All as a submenu designation; I was certainly never confused on what Clear did.

I think using one word for the functionality across the application, whether it be clear or remove, is the best option. Using two different words for the same function even if they're different in scope makes the app confusing. As opposed to Clear and Clear All have Remove and Remove Options, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants