Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V19 & Type interference #4663

Closed
2 tasks
leomayer opened this issue Jan 8, 2025 · 1 comment
Closed
2 tasks

V19 & Type interference #4663

leomayer opened this issue Jan 8, 2025 · 1 comment

Comments

@leomayer
Copy link

leomayer commented Jan 8, 2025

Which @ngrx/* package(s) are the source of the bug?

signals

Minimal reproduction of the bug/regression with instructions

In V18 I could define my types - as well for the SignalFeatures. The types were forwarded to the store as well.
In V19 it doesn't seem that these types are forwarded.

Expected behavior

Sample:
https://stackblitz.com/edit/github-3tadjc91?file=src/quiz-additonal.state.ts,src/quiz.store.ts,src/main.ts

although I have to admit it might not make much sense. I tried to get a sample for #4661 but this is now already resolved!

isChecked cannot be found although available.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)

NgRx: V19 ...

Other information

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@markostanimirovic
Copy link
Member

V19 migration guide

SignalStoreFeatureResult.computed is replaced with SignalStoreFeatureResult.props:

export type QuizAdditional = EmptyFeatureResult & {
  state: CheckingType;
-  computed: {
   props: {
    isChecked: Signal<boolean>;
  };
};

We use GitHub issues for bug reports and feature requests. For further questions, please open a new GitHub Discussion. Thanks!

@markostanimirovic markostanimirovic closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants