Redirect using 308 for non-GET requests

nginx-proxy · Aug 18, 2021 · 62202f9 · 62202f9
1 parent ded3cfc
commit 62202f9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -292,6  292,7 @@ Note that the `Mozilla-Old` policy should use a 1024 bits DH key for compatibili
 The default behavior for the proxy when port 80 and 443 are exposed is as follows:
 
 * If a container has a usable cert, port 80 will redirect to 443 for that container so that HTTPS is always preferred when available.
   * This redirect will use a 301 code for GET requests and 308 code for any other http method (POST/HEAD/PUT etc.). A 308 redirect is a more recent version of 301 permanent redirect that maintains the http method. Previously, 301 redirects would all be converted into GET requests.
 * If the container does not have a usable cert, a 503 will be returned.
 
 Note that in the latter case, a browser may get an connection error as no certificate is available to establish a connection. A self-signed or generic cert named `default.crt` and `default.key` will allow a client browser to make a SSL connection (likely w/ a warning) and subsequently receive a 500.

diff --git a/nginx.tmpl b/nginx.tmpl
@@ -276,11  276,20 @@ server {
 	}
 
 	location / {
-		{{ if eq $external_https_port "443" }}
-		return 301 https://$host$request_uri;
-		{{ else }}
-		return 301 https://$host:{{ $external_https_port }}$request_uri;
-		{{ end }}
 		if ($request_method = GET) {
 			{{ if eq $external_https_port "443" }}
 			return 301 https://$host$request_uri;
 			{{ else }}
 			return 301 https://$host:{{ $external_https_port }}$request_uri;
 			{{ end }}
 		}
 		if ($request_method != GET) {
 			{{ if eq $external_https_port "443" }}
 			return 308 https://$host$request_uri;
 			{{ else }}
 			return 308 https://$host:{{ $external_https_port }}$request_uri;
 			{{ end }}
 		}
 	}
 }
 {{ end }}