Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(caldav): rename default calendar to keep it in the trashbin instead of purging it #50144

Open
wants to merge 1 commit into
base: stable30
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 11, 2025

Backport of PR #50034

…ad of purging it

When doing a PROPFIND on default-calendar-url, if the current default calendar (fallbacking on personal uri)
is in the trashbin, it's being purged so that it's recreated.

This leads to loss of data.

We can simply rename the calendar URI and add a unique suffix so that it doesn't conflict with the new calendar
being created.
Shares are fine because they reference the resourceid and not the calendar URI.

Signed-off-by: Thomas Citharel <[email protected]>
@backportbot backportbot bot requested a review from ChristophWurst January 11, 2025 15:36
@backportbot backportbot bot requested a review from tcitworld as a code owner January 11, 2025 15:36
@backportbot backportbot bot requested a review from st3iny January 11, 2025 15:36
@backportbot backportbot bot added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Jan 11, 2025
@backportbot backportbot bot added this to the Nextcloud 30.0.5 milestone Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants