-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Treeview Widget #380
Conversation
Releasing Termdash v0.20.0.
Hello @keithknott26 and thank you, this looks great! Thank you for adding a new widget and including solid test coverage. It will take me a bit to review this. I will get back to you if I see any points we need to address. |
I just had some time to play with the demo, the Going to start reviewing it shortly. |
@keithknott26, while I am reviewing this - do you want to update this PR adding a screenshot of this widget and its capabilities to the main README? It doesn't have to be a moving gif like the other ones, but can be if you want to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Keith, just a few comments. Most of them optional for your consideration.
Thanks! Let me know if you think anything else should be updated. Cheers, |
Looks great, thank you very much for iterating @keithknott26 and for adding the animated gif that shows the main features of this widget. I will review the other widget shortly, so we can release them to the master branch together. |
Hello Jakob,
Thanks for your hard work on this project, I often think about ways I could use it in my development efforts. Anyway, I've added a Treeview widget, demo, and tests to a fork of your repo under keithknott26/termdash. I felt I should contribute something hopefully useful to this effort.
Let me know if you'd like me to make any changes, the test coverage is not ideal given I wasn't too familiar with writing them for a UI type application. Mutex locks are in place so there are currently no race conditions as far as I know. Mouse and keyboard integration are included.
Cheers,
Keith Knott