Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Treeview Widget #380

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Adding Treeview Widget #380

merged 9 commits into from
Sep 24, 2024

Conversation

keithknott26
Copy link

Hello Jakob,

Thanks for your hard work on this project, I often think about ways I could use it in my development efforts. Anyway, I've added a Treeview widget, demo, and tests to a fork of your repo under keithknott26/termdash. I felt I should contribute something hopefully useful to this effort.

Let me know if you'd like me to make any changes, the test coverage is not ideal given I wasn't too familiar with writing them for a UI type application. Mutex locks are in place so there are currently no race conditions as far as I know. Mouse and keyboard integration are included.

Cheers,
Keith Knott

@mum4k
Copy link
Owner

mum4k commented Sep 16, 2024

Hello @keithknott26 and thank you, this looks great! Thank you for adding a new widget and including solid test coverage. It will take me a bit to review this. I will get back to you if I see any points we need to address.

@mum4k mum4k self-assigned this Sep 16, 2024
@mum4k mum4k changed the base branch from master to devel September 18, 2024 18:16
@mum4k
Copy link
Owner

mum4k commented Sep 18, 2024

I just had some time to play with the demo, the treeview widget looks really cool, thank you @keithknott26!

Going to start reviewing it shortly.

@mum4k
Copy link
Owner

mum4k commented Sep 18, 2024

@keithknott26, while I am reviewing this - do you want to update this PR adding a screenshot of this widget and its capabilities to the main README? It doesn't have to be a moving gif like the other ones, but can be if you want to.

Copy link
Owner

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Keith, just a few comments. Most of them optional for your consideration.

widgets/treeview/treeview.go Outdated Show resolved Hide resolved
widgets/treeview/treeview.go Outdated Show resolved Hide resolved
widgets/treeview/treeview.go Outdated Show resolved Hide resolved
widgets/treeview/treeview.go Outdated Show resolved Hide resolved
widgets/treeview/treeview.go Outdated Show resolved Hide resolved
widgets/treeview/treeview.go Outdated Show resolved Hide resolved
widgets/treeview/treeview.go Outdated Show resolved Hide resolved
@keithknott26
Copy link
Author

Thanks!
I've incorporated your suggestions and updated the following:
Treeview to TreeView
Added missing comments to types
Changed node to tv
Updates to mutex locking
Added more tests
README.md file was updated with an animated gif

Let me know if you think anything else should be updated.

Cheers,
Keith

@mum4k
Copy link
Owner

mum4k commented Sep 24, 2024

Looks great, thank you very much for iterating @keithknott26 and for adding the animated gif that shows the main features of this widget. I will review the other widget shortly, so we can release them to the master branch together.

@mum4k mum4k merged commit 9b96347 into mum4k:devel Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants