Support high-resolution stats; add audio stats framework #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't performed a detailed review yet, but it looks great at first glance. I will mark this for the v6.2 milestone, since v6.1 must ship in the next couple days to fix #1355 for Sequoia. |
|
Sounds good. I know large patches are a pain and I sometimes get a bit carried away, so I appreciate the review. |
andygrundman
force-pushed
the
andyg.hires-timing-and-stats-qt
branch
from
fd72eeb to
aa3e51d
Compare
andygrundman
force-pushed
the
andyg.hires-timing-and-stats-qt
branch
2 times, most recently
from
537742b to
d8f87a5
Compare
NOTE: this patch depends on a patch to moonlight-common-c, see [this PR](moonlight-stream/moonlight-common-c#95). * Adds an audio stats overlay that works with all current renderers, showing common info such as bitrate and packet loss. It is blue and in the upper-right, and will appear whenever the video overlay is enabled. * Audio renderers are able to add more lines to the overlay (the upcoming CoreAudio patch uses this). * Added bitrate/FEC display to both video and audio stats. * Consolidated the 3 FPS lines into one to save a bit of space. * All time-based stats are now microsecond-based, improving accuracy of very fast events.
andygrundman
force-pushed
the
andyg.hires-timing-and-stats-qt
branch
from
d8f87a5 to
6391520
Compare
|
This layout is not ideal on small screens, should probably just go below video stats.
(And may I suggest adding the renderer platform to the video side too, since audio seems to have it. It's a bit of a hassle to figure out if you're running on Xwayland for example...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this patch depends on a patch to moonlight-common-c, see this PR.