-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python multi namespace #5375
Python multi namespace #5375
Conversation
…hon-multi-namespace
…hon-multi-namespace
packages/http-client-python/generator/pygen/codegen/serializers/base_serializer.py
Show resolved
Hide resolved
packages/http-client-python/generator/pygen/codegen/models/code_model.py
Show resolved
Hide resolved
packages/http-client-python/generator/pygen/codegen/serializers/__init__.py
Show resolved
Hide resolved
packages/http-client-python/generator/pygen/codegen/serializers/__init__.py
Show resolved
Hide resolved
packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py
Show resolved
Hide resolved
packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes lgtm. but i really think we should do a refactor to separate the logic of serializing and type status in some time. current logic of import and other serialization thing has too many coupling things. another thing is we should hold merge till we add complicated test cases in spector.
packages/http-client-python/generator/pygen/codegen/models/base_builder.py
Show resolved
Hide resolved
…hon-multi-namespace
1ca0873
to
0c216f2
Compare
As discussed, we could refactor the implementation after this PR since refactor doesn't influence SDK API. And it will be more safe for refactor if there are already some tests. |
For Azure/autorest.python#2795.
Compared to the previous logic that only supported a single namespace, this PR introduces support for multiple namespaces. This primarily requires updates in two key areas:
imports
function.Considering these two main changes, here's a detailed summary of the updates in this PR:
enable-typespec-namespace
, which lets users decide if they want to support native typespec namespace.clientNamespace
for models/operations/enums/namedUnions/clients: the emitter usesclientNamespace
to determine the exact location where the target type should be.get_relative_import_path
for CodeModel: all relative import paths should be calculated using this function.client_namespace_types
to CodeModel: it counts and stores all namespace types and information aboutclients/operation_groups/enums/models
in each namespace.client_namespace_types
property in CodeModel, we can cycle through each namespace and serialize its clients/models/enums/operations using the same logic.relative_path
andoperation
kwargs, which were not set from the top caller but from various functions during the calling process. The signatures were difficult to understand and maintain. I replaces them with the newserialize_namespace
andserialize_namespace_type
kwargs. Now, any function that needs to calculate relative imports can use these two parameters, which are set from the top caller, making them easier to understand and maintain.