Fix landing #1598
ci.yaml
on: pull_request
Typecheck
38s
Format & Lint (Biome)
26s
Format (Cargo)
12s
Clippy
2m 24s
Annotations
4 errors and 7 warnings
Typecheck:
apps/landing/src/routes/docs.tsx#L12
Cannot find module 'content-collections' or its corresponding type declarations.
|
Typecheck:
apps/landing/src/routes/docs/[...rest].tsx#L2
Cannot find module 'content-collections' or its corresponding type declarations.
|
Typecheck:
apps/landing/src/routes/docs/[...rest].tsx#L12
Parameter 'd' implicitly has an 'any' type.
|
Typecheck
Process completed with exit code 2.
|
Format & Lint (Biome)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
direct implementation of `ToString`:
crates/ms-ddf/src/ddf_v2.rs#L135
warning: direct implementation of `ToString`
--> crates/ms-ddf/src/ddf_v2.rs:135:1
|
135 | / impl ToString for DFFormatVariant {
136 | | fn to_string(&self) -> String {
137 | | match self {
138 | | DFFormatVariant::Base64 => "b64".to_string(),
... |
150 | | }
151 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
this seems like a manual implementation of the non-exhaustive pattern:
apps/mattraxd/src/cli/mod.rs#L13
warning: this seems like a manual implementation of the non-exhaustive pattern
--> apps/mattraxd/src/cli/mod.rs:13:1
|
13 | pub struct Cli {
| ^-------------
| |
| _help: add the attribute: `#[non_exhaustive] pub struct Cli`
| |
14 | | #[arg(short, long)]
15 | | pub data_dir: Option<PathBuf>,
... |
22 | | pub command: Commands,
23 | | }
| |_^
|
help: remove this field
--> apps/mattraxd/src/cli/mod.rs:19:5
|
19 | version: (),
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
= note: `#[warn(clippy::manual_non_exhaustive)]` on by default
|
usage of `&String::new()` for a function expecting a `&str` argument:
apps/ingest/src/windows_ddf.rs#L73
warning: usage of `&String::new()` for a function expecting a `&str` argument
--> apps/ingest/src/windows_ddf.rs:73:57
|
73 | nodes.extend(handle_node(child, &String::new(), scope));
| ^^^^^^^^^^^^^^ help: try: `""`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_owned_empty_strings
= note: `#[warn(clippy::unnecessary_owned_empty_strings)]` on by default
|
comparison to empty slice:
apps/ingest/src/windows_ddf.rs#L170
warning: comparison to empty slice
--> apps/ingest/src/windows_ddf.rs:170:16
|
170 | if path == "" {
| ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
= note: `#[warn(clippy::comparison_to_empty)]` on by default
|
comparison to empty slice:
apps/ingest/src/windows_ddf.rs#L181
warning: comparison to empty slice
--> apps/ingest/src/windows_ddf.rs:181:12
|
181 | if path == "" || path == "/" {
| ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
|
comparison to empty slice:
apps/ingest/src/windows_ddf.rs#L187
warning: comparison to empty slice
--> apps/ingest/src/windows_ddf.rs:187:12
|
187 | if path == "" || path == "/" {
| ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
|