Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-59253]: Remove plugin code from focalboard repo #5027

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[MM-59253]: Remove plugin code from focalboard repo #5027

wants to merge 9 commits into from

Conversation

Rajat-Dabade
Copy link
Contributor

This PR include:

  • Removing isPlugin check from webapp.

@Rajat-Dabade Rajat-Dabade self-assigned this Jul 23, 2024
@marianunez marianunez requested a review from jespino July 23, 2024 13:48
marianunez
marianunez reviewed Jul 25, 2024
View reviewed changes
docker-testing/docker-compose-mysql.yml Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
webapp/src/components/boardsSwitcher/boardsSwitcher.tsx Show resolved Hide resolved
webapp/src/components/shareBoard/shareBoard.tsx Show resolved Hide resolved
webapp/src/components/sidebar/sidebar.tsx Show resolved Hide resolved
webapp/src/components/withWebSockets.tsx Outdated Show resolved Hide resolved
@Rajat-Dabade Rajat-Dabade added 2: Dev Review Requires review by a core committer Do Not Merge Should not be merged until this label is removed labels Jul 29, 2024
@Rajat-Dabade Rajat-Dabade mentioned this pull request Jul 30, 2024
Open
marianunez
marianunez approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rajat-Dabade ! Some minor comments below

.vscode/settings.json Show resolved Hide resolved
webapp/src/components/cardDialog.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianunez marianunez marianunez approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

@jespino jespino Awaiting requested review from jespino

Assignees

@Rajat-Dabade Rajat-Dabade

Labels
2: Dev Review Requires review by a core committer Do Not Merge Should not be merged until this label is removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rajat-Dabade @marianunez @harshilsharma63