Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GC's panic(), use Warn log instead: GC-PANIC #20910

Merged
merged 7 commits into from
Dec 25, 2024
Merged

Remove GC's panic(), use Warn log instead: GC-PANIC #20910

merged 7 commits into from
Dec 25, 2024

Conversation

LeftHandCold
Copy link
Contributor

@LeftHandCold LeftHandCold commented Dec 24, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #20909

What this PR does / why we need it:

Remove GC's panic(), use Warn log instead: GC-PANIC

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Dec 24, 2024
@mergify mergify bot requested a review from sukki37 December 24, 2024 09:15
@mergify mergify bot added the kind/refactor Code refactor label Dec 24, 2024
@LeftHandCold LeftHandCold changed the title Remove GC's panic(), use Warn log instead: [GC-WARNING-PANIC] Remove GC's panic(), use Warn log instead: GC-PANIC Dec 25, 2024
@matrix-meow matrix-meow added size/M Denotes a PR that changes [100,499] lines and removed size/S Denotes a PR that changes [10,99] lines labels Dec 25, 2024
@sukki37 sukki37 merged commit f48a2aa into matrixorigin:2.0-dev Dec 25, 2024
15 of 16 checks passed
@LeftHandCold LeftHandCold deleted the reomve-gc-panic-2.0 branch December 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

@sukki37 sukki37 Awaiting requested review from sukki37

Assignees
No one assigned
Labels
kind/refactor Code refactor size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeftHandCold @XuPeng-SH @sukki37 @matrix-meow