Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring]: move projectList to Node in createQuery(for some case), not compileProjection #20623

Closed
ouyuanning opened this issue Dec 6, 2024 · 0 comments
Closed

[Refactoring]: move projectList to Node in createQuery(for some case), not compileProjection #20623

ouyuanning opened this issue Dec 6, 2024 · 0 comments
Assignees
@ouyuanning
Labels
kind/refactor Code refactor priority/p0.5
Milestone
2.1.0

Comments

@ouyuanning
Copy link
Contributor

Why do you want to refactor this code?

目前在compileProjection的时候，会讲一些情况下的Projection放入到前一个算子中。
之前跟喜亮发现，这样会导致部分Projection节点的统计信息会变成0.（因为这个节点实际已经不存在了）
讨论后，建议的方案是，看这个移动的动作，是否可以提前到build plan的时候处理。

比如在 QueryBuilder.createQuery 的时候。作为一个优化规则来处理

Describe the solution you'd like

同上

Describe alternatives you've considered

No response

Additional information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouyuanning ouyuanning

Labels
kind/refactor Code refactor priority/p0.5
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@ouyuanning @huby2358