Universal jQuery module loader #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Could you please create a new tag 1.3.2 before accepted this pull request and a new tag 1.3.3 after accepted this pull request. |
|
Hey mate. Sorry for not getting back to you (at all or anyone else for that matter) kinda forgot about this, but originally I want this project to be pure vanilla JS so that anyone can pull and use it out-of-the-box :) If you want - feel free to fork the project and make a jQuery version :) But, if we made a "jQuery" branch - is there any drawbacks? Apart form maintaining two "master" branches. WHats your thoughts? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16 (comment)
Hi Marrio,
Thank you for this great js plugin,we planned to use it in our project and it will be awesome if you convert your plugin to an Jquery Plugin.
check this Example to create an Universal JS module loader:
https://github.com/umdjs/umd/blob/master/templates/jqueryPlugin.js
Regards,