appimage: use full path of appimagetool (#2771)

marcelotduarte · Jan 9, 2025 · f0d4ece · f0d4ece
1 parent 0db6d1a
commit f0d4ece
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -128,7 +128,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        python-version: ["3.12"]
+        python-version: ["3.11"]
         extra-requirement:
           - lief==0.15.1
           - lief==0.14.1

diff --git a/cx_Freeze/command/bdist_appimage.py b/cx_Freeze/command/bdist_appimage.py
@@ -29,8 +29,9 @@
 
 ARCH = platform.machine()
 APPIMAGEKIT_URL = "https://github.com/AppImage/AppImageKit/releases"
+APPIMAGEKIT_URL = "https://github.com/AppImage/appimagetool/releases"
 APPIMAGEKIT_PATH = f"download/continuous/appimagetool-{ARCH}.AppImage"
-APPIMAGEKIT_TOOL = "~/.local/bin/appimagetool"
+APPIMAGEKIT_TOOL = f"~/.local/bin/appimagetool-{ARCH}.AppImage"
 
 
 class bdist_appimage(Command):
@@ -160,20 +161,11 @@ def _get_appimagekit(self) -> None:
                     f"download and install AppImageKit from {APPIMAGEKIT_URL}",
                     INFO,
                 )
-                name = os.path.basename(APPIMAGEKIT_PATH)
-                filename = os.path.join(appimagekit_dir, name)
-                if not os.path.exists(filename):
-                    urlretrieve(  # noqa: S310
-                        os.path.join(APPIMAGEKIT_URL, APPIMAGEKIT_PATH),
-                        filename,
-                    )
-                    os.chmod(filename, stat.S_IRWXU)
-                if not os.path.exists(appimagekit):
-                    self.execute(
-                        os.symlink,
-                        (filename, appimagekit),
-                        msg=f"linking {appimagekit} -> {filename}",
-                    )
+                urlretrieve(  # noqa: S310
+                    os.path.join(APPIMAGEKIT_URL, APPIMAGEKIT_PATH),
+                    appimagekit,
+                )
+                os.chmod(appimagekit, stat.S_IRWXU)
         self.appimagekit = appimagekit
 
     def run(self) -> None: