Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Remove Move.CapturedPiece #1020

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

⚡ Remove Move.CapturedPiece #1020

wants to merge 11 commits into from

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Sep 17, 2024 •
edited
Loading

It gets cumbersome for capture history, since we gotta save visited moves and captured piece.
Something is still off though, since bench doesn"t match.

Score of Lynx-perf-board-bitboard-remove-move-capturedpiece-3932-win-x64 vs Lynx-perf-board-bitboard-remove-makemovecalculatingcapturedpiece-3929-win-x64: 1568 - 1690 - 2540  [0.489] 5798
...      Lynx-perf-board-bitboard-remove-move-capturedpiece-3932-win-x64 playing White: 1197 - 405 - 1297  [0.637] 2899
...      Lynx-perf-board-bitboard-remove-move-capturedpiece-3932-win-x64 playing Black: 371 - 1285 - 1243  [0.342] 2899
...      White vs Black: 2482 - 776 - 2540  [0.647] 5798
Elo difference: -7.3 +/- 6.7, LOS: 1.6 %, DrawRatio: 43.8 %
SPRT: llr -2.26 (-78.2%), lbound -2.25, ubound 2.89 - H0 was accepted

Base automatically changed from perf/board-bitboard-remove-MakeMoveCalculatingCapturedPiece to main September 17, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eduherminio