-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate PodCondition setting by api-server #129351
base: master
Are you sure you want to change the base?
Remove duplicate PodCondition setting by api-server #129351
Conversation
The PodScheduled condition should not be set by kube-apiserver since kubelet already sets it.
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @rohitcncf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohitcncf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig node |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a bug where the PodScheduled condition was being created by kube-apiserver and Kubelet.
PatchPodStatus
is called which updates the status and thus field manager is updated tokubelet
.There are two places where this happens. Removing the kubeapiserver part of it since the issue says
kubelet
should be the status manager.Which issue(s) this PR fixes:
Fixes #127508
Does this PR introduce a user-facing change?
No
I am new contributor. Please suggest me the right solution if this is not the correct solution.