Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup.py uses a removed pypandoc.convert method #492

Closed
xlucn opened this issue Dec 23, 2024 · 1 comment
Closed

Setup.py uses a removed pypandoc.convert method #492

xlucn opened this issue Dec 23, 2024 · 1 comment
Labels
bug this shouldn't be happening

Comments

@xlucn
Copy link
Contributor

xlucn commented Dec 23, 2024

** Dynesty version **
2.1.4. From Arch Linux's AUR package, which builds and installs with source files.

Describe the bug
During build (python -m build --wheel --no-isolation), I run into an error:

Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    main()
    ~~~~^^
  File "/usr/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
    return hook(config_settings)
  File "/usr/lib/python3.13/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
    return self._get_build_requires(config_settings, requirements=[])
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
    self.run_setup()
    ~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/setuptools/build_meta.py", line 516, in run_setup
    super().run_setup(setup_script=setup_script)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/setuptools/build_meta.py", line 318, in run_setup
    exec(code, locals())
    ~~~~^^^^^^^^^^^^^^^^
  File "<string>", line 24, in <module>
AttributeError: module 'pypandoc' has no attribute 'convert'

Which points to this line in code:

dynesty/setup.py

Line 24 in 55d93d0

long_description = pypandoc.convert(txt, 'rst', 'md')

This pypandoc.convert method was removed (see JessicaTegner/pypandoc@3e296b7#diff-260af425b84a1eb4003b6bd017e57110226490652c6e97633dc33ce75359face), and thus the code here needs a fix as well.

Setup
Irrelevant, this is a installation issue.

** Dynesty output **
Irrelevant, this is a installation issue.

Bug

Additional context
I guess most users don't have pypandoc installed thus haven't run into this issue. And I have pypandoc installed recently thus haven't run into it until now.
@xlucn xlucn added the bug this shouldn't be happening label Dec 23, 2024
@xlucn
Copy link
Contributor Author

xlucn commented Dec 23, 2024

I find this easy to fix. I will come up with a PR soon.

@xlucn xlucn mentioned this issue Dec 23, 2024
Merged
@segasai segasai closed this as completed in 8a7bf66 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug this shouldn't be happening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xlucn