Update ContenthistoryHelper to use absolute image paths #44645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first PR and regarding issue joomla#44635
|
@Attila-SWE Thanks for your first PR. Please close the issue. I will test the PR but wan't to wait first if there is Feedback. |
|
Done! So if I understand correctly then first create issue, then create pull request referring to issue and close issue? Is there any "documentation" for this regarding Joomla that I could read up on? |
|
If you create a PR no Issue is needed. I don't know about Documentation for this workflow. |
alikon
reviewed
Dec 20, 2024
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
|
@alikon Makes it sense to test the Pull Request as |
|
@fgsw drone is failing at Code style step |
alikon
reviewed
Dec 21, 2024
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
Sorry for many small changes. First PR.
alikon
reviewed
Dec 21, 2024
administrator/components/com_contenthistory/src/Helper/ContenthistoryHelper.php
Outdated
Show resolved
Hide resolved
alikon
suggested changes
Dec 21, 2024
|
NP! Thanks for helping me learn |
hoping is the last 1 for code syle
code style for your joomla#44645
|
I have tested this item ✅ successfully on ecd0668
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44645. |
|
Thank you very much @Attila-SWE and congratulations to your first PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR so sorry if I messed something up. Please give me feedback then. Some considerations is that this only fixes images in images/ folder and does not fix other relative URL:s or such. Perhaps a broader fix is necessary?
Pull Request for Issue #44635.
Summary of Changes
Check to see if values in content history includes images with relative /images url
Testing Instructions
Open preview of content history with images in content with relative urls like images/test.png
Actual result BEFORE applying this Pull Request
Images broken because urls are relative to /administrator/ so for example DOMAIN/administrator/images/test.png
Expected result AFTER applying this Pull Request
Images shown and url of images is DOMAIN/images/test.png
Link to documentations
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed