Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to utilize test_split() #18

Closed
halqadasi opened this issue May 27, 2023 · 1 comment
Closed

How to utilize test_split() #18

halqadasi opened this issue May 27, 2023 · 1 comment

Comments

@halqadasi
Copy link

halqadasi commented May 27, 2023

Thank you so much for your impressive work, I tried many tools but their performance were not like yours. But I spent a lot of time to figure out how I can use test_split() but I did not figure out where I should use it, could you please tell me in which line I should use it in main_test_fbcnn_color_real.py what should be the input parameters.

          Hello, thanks for your interest in our work! 
  1. The function you mentioned is mainly used for generating small patches for fast training. For testing large images, please try to utilize the function test_split from utils_model.py: https://github.com/jiaxi-jiang/FBCNN/blob/main/utils/utils_model.py#L214

  2. For fair comparisons, we follow the convention of prior work to use 8 bit depth image for training and testing. Intuitively training with 16 bit depth images should be better for testing 16 bit depth images, but I think not necessary for testing 8 bit depth images. We can discuss more if you are interested in this part.

Feel free to ask me if you still have questions.

Originally posted by @jiaxi-jiang in #12 (comment)

@jiaxi-jiang
Copy link
Owner

the test_split function was directly borrowed from other codebases. They assume the input and output are just images. However, our model has the quality factor as output and optionally input. So it needs some lines of adaption to make it work with our model.
For testing very large images, the easiest way is to run on CPUs so the memory should be large enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants