-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buying champ then selling it directly #15
Comments
Is it trying to place items after already in PVP in the last screen shot? Also I assume you modified the "level": 2 in the comps.py file? |
I'm also getting this problem and script tries to put items during PVP |
In the comp.py file, the Level, is it the level of the champ? (1 star, 2 stars, 3stars?) or the level of the Tactician? |
Sometimes, and especially after the PVE fight (against raptors and others), the script takes a lot of time to gather the items, to the point that when it is done, and it goes into the buying champ phase it does buy, then in the log it shows "Placing CHAMP on board" but the PVP fight has already started, and the champ is still benched. This sometimes leads to a random champ taking a random hex, but the overlay still shows the CHAMP (that has been bought) is placed. |
@jfd02 Any idea about this behavior? |
Sorry for the delay, was taking a break. To be honest, I'm not sure how to implement the solution I have in mind and would need someone to contribute to this. My idea is to calculate the location of the orbs on the board using using the RGB codes of the orb (I can do this part), once you have these positions I assume you would need to find the position on the screen to click which can't be on the board because it may be on top of a champion. So you take your position and the target position, find the slope of the line and calculate the first position where x is farther right then the board and click there. Then you would need to recalculate for the next orb on the board. Picture for better example: |
Is it possible to read game memory? Just like the project of Lmeme. It is easy to get items object world position, you can filter it by object name, then use worldToScreen and click it. Meanwhile, it make everything becoming easy. It can never fail when check bench hero. (I never get 3 star hero, because it will sell all bench hero when it will be successful. ) |
Yeah its possible |
ASU GL553VD:
|
You should probably try resetting league of legends' internal brightness/vibrance/contrast sliders to default values. i boldly assume it uses some sort of image recognition to detect each champion, which any deviance from how the software knows a champion is supposed to look (like changing it's color levels) would make it harder for it or in some cases impossible to detect. Reason i'm saying this is your screenshot looks abnormally bright compared to what it should look like at default values. Feel like it's a good guess, but i didn't have a look under the hood nor the expertise to make sense of most any of it. |
There is no image recognition in the bot, only OCR and checking pixel colors. So it may be possible the color settings do mess with the health bar color which is a way the bot checks if a slot is occupied which may mess things up. I'm not confident the logic isn't at fault either though as there is a lot of edge cases such as picking up an orb causing a champion on the board to change tiers, removing the champions on the bench. |
Ah, I see. Worth mentioning anyway. I think specifically the UI is unaffected by those values actually. |
Hello man,
First, I'd like to thank you for this tremendous work, gg wp!!
After using it for some time, I notice that sometimes, the bot buys Illaoi or Tristana for example, then they don't get a name in the overlay, and right after the buying phase, he sells them, and the log says: Selling unknown champion.
Is there any way this can be fixed? because it makes the comp aways on a 1-star champs.
Oh, one more question, is there any way to make it work with 1366x768 monitors? I tried it on a laptop, and it is stuck at "Loading screen found! Waiting for round 1-1"
Thanks again!!
The text was updated successfully, but these errors were encountered: