Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated details #18459

Closed
wants to merge 3 commits into from
Closed

updated details #18459

wants to merge 3 commits into from

Conversation

raghu-8
Copy link
Contributor

@raghu-8 raghu-8 commented Jan 14, 2025

Requirements

Unless explicitly specified otherwise by a maintainer or in the requirement description, your domain MUST pass ALL the indicated requirements below.

  • I have read and understood the Terms of Service.
  • My domain is not for commercial use.
  • My file is in the domains folder and is in the JSON format.
  • My file"s name is all lowercased and alphanumeric.
  • The website is reachable.
  • I have completed my website.
  • My website is related to software development.
  • I have provided contact information in the owner key.
  • I have followed the documentation.
  • I understand my domain may be removed if I violate the Terms of Service.

Website Preview

@raghu-8 raghu-8 requested a review from a team as a code owner January 14, 2025 16:28
@@ -0,0 +1,11 @@
{
"description": "Link for Raghu's personal site on Vercel",
"link":"https://windows-portfolio.vercel.app/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid

Suggested change
"link":"https://windows-portfolio.vercel.app/",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid

btw @Satindar31 that doesn"t rlly make a difference
like it"d be just ignored as long as the JSON is valid and the records too

"email": "[email protected]"
},
"record": {
"TXT": "vc-domain-verify=raghu.is-a.dev,64be76cc9f11decf61dd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete... See Vercel docs

"email": "[email protected]"
},
"record": {
"TXT": "vc-domain-verify=raghu.is-a.dev,64be76cc9f11decf61dd"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TXT records alone do nothing, and this verification string goes on a _vercel subdomain
see https://docs.is-a.dev/guides/vercel/

@Stef-00012 Stef-00012 added the reason: invalid records Your records are not valid or improper. label Jan 14, 2025
@omsenjalia
Copy link
Contributor

RTFM

@omsenjalia omsenjalia closed this Jan 17, 2025
@raghu-8
Copy link
Contributor Author

raghu-8 commented Jan 18, 2025

Apologies for the trouble. Kindly take a look at the image and share any suggestions or ideas.

image

@iostpa
Copy link
Member

iostpa commented Jan 18, 2025

Read the documentation :D
https://docs.is-a.dev/guides/vercel/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain reason: invalid records Your records are not valid or improper.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants