Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand emission scaling parameterization to allow representing GWP* #469

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

expand emission scaling parameterization to allow representing GWP* #469

wants to merge 1 commit into from

Conversation

volker-krey
Copy link
Contributor

Addition to GAMS code that expands emission scaling parameterization to allow representing GWPstar metric

How to review

  • Check the formulation in GAMS equation EMISSION_CONSTRAINT in model_core.gms and comment on adequacy and correctness of equation
  • Check the diff for parameter_def.gms and data_load.gms
  • Following initial conceptual discussion the other (hidden in this list) steps may need to be performed as part of review

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@volker-krey volker-krey added the enh New features & functionality label May 14, 2021
@volker-krey volker-krey self-assigned this May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021 •
edited
Loading

Codecov Report

Merging #469 (3a3cc43) into main (22de076) will increase coverage by 93.3%.
The diff coverage is n/a.

❗ Current head 3a3cc43 differs from pull request most recent head 53cd050. Consider uploading reports for the commit 53cd050 to get more accurate results

@@           Coverage Diff           @@
##           main    #469       /-   ##
=======================================
  Coverage      0   93.3%    93.3%     
=======================================
  Files         0      37       37     
  Lines         0    2814     2814     
=======================================
  Hits          0    2627     2627     
- Misses        0     187      187
Impacted Files Coverage Δ
message_ix/reporting/__init__.py 100.0% <0.0%> (ø)
message_ix/__init__.py 89.4% <0.0%> (ø)
message_ix/tests/test_tutorials.py 100.0% <0.0%> (ø)
message_ix/tests/test_core.py 100.0% <0.0%> (ø)
message_ix/tests/test_util.py 100.0% <0.0%> (ø)
message_ix/tests/test_cli.py 100.0% <0.0%> (ø)
message_ix/tools/add_year/__init__.py 66.2% <0.0%> (ø)
message_ix/models.py 100.0% <0.0%> (ø)
message_ix/utils.py 100.0% <0.0%> (ø)
message_ix/core.py 95.2% <0.0%> (ø)
... and 27 more

@volker-krey @OFR-IIASA
expand emission scaling parameterization to allow representing GWP*
53cd050 
Note that data_load.gms includes dummy code that sets the newly introduced emission_diff_scaling to zero in the absence of the parameter being included in the GDX setup so far.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@volker-krey volker-krey

Labels
enh New features & functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@volker-krey