Persist display columns #406
Conversation
…te ui when columns are changed
🦋 Changeset detectedLatest commit: 922f2d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -410,7 410,7 @@ export const RawLogTable = memo( | |||
| size: columnSizeStorage[column] ?? 150, | |||
| })) as ColumnDef<any>[]), | |||
| { | |||
| accessorKey: 'body', | |||
| accessorKey: 'show-pattern', | |||
There was a problem hiding this comment.
@MikeShi42 Changed accessorKey from 'body' to 'show-pattern' as it was conflicting with 'body' custom column
There was a problem hiding this comment.
accessorKey should stay body as it renders log's body property, could you provide more context on why it conflicts with custom columns?
There was a problem hiding this comment.
When custom column 'body' is added it conflicts with the 'message' column which has the same accessorKey
This causes duplicate of body when switching to other search views in this instance:
Not sure if there is a different way to resolve this
| @@ -531,7 531,8 @@ const api = { | |||
| { | |||
| name: string; | |||
| query: string; | |||
| tags?: string; | |||
| tags?: string[]; | |||
There was a problem hiding this comment.
@MikeShi42 Changed tag type from string to string[], not sure if that is accurate. Please correct if wrong
|
Is there is a chance to finish and merge this? 🥺 |
fixes #152