Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Modes - by key, by value, by both #24

Open
hrishikeshrt opened this issue Apr 16, 2022 · 5 comments
Open

Search Modes - by key, by value, by both #24

hrishikeshrt opened this issue Apr 16, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone
Release of stable...

Comments

@hrishikeshrt
Copy link
Owner

  • PyCDSL version: 0.7.0
  • Python version: 3.8.8
  • Operating System: Ubuntu 18.04.6 LTS

Problem

Was trying to find words with specific meaning / similar meaning.

Feature Description

  • search() function can have a mode argument, with possible values say 'key', 'value', 'both'

Reasons

One way is to use the English dictionaries, but use case might be more, where we just want to find related words etc.
It can be a good addition to allow search by value or key or both.
@hrishikeshrt hrishikeshrt added enhancement New feature or request in progress Currently being worked upon labels Apr 16, 2022
@hrishikeshrt
Copy link
Owner Author

hrishikeshrt commented Apr 16, 2022 •
edited
Loading

TODO

  • Implement core functionality in lexicon.py
  • Expose properly in corpus.py
  • Make it available through shell.py
  • Make it available through cli.py
  • Add documentation
  • Add tests

@hrishikeshrt
Copy link
Owner Author

hrishikeshrt commented Apr 16, 2022 •
edited
Loading

Lexicon level implementation 852763e complete.

@hrishikeshrt
Copy link
Owner Author

hrishikeshrt commented Apr 16, 2022 •
edited
Loading

Corpus level implementation 0c8b3f7 complete.

@hrishikeshrt
Copy link
Owner Author

hrishikeshrt commented Apr 16, 2022 •
edited
Loading

CLI and Shell implementations (dab6784 and d792eb3) complete.

@hrishikeshrt hrishikeshrt removed the in progress Currently being worked upon label Apr 16, 2022
@hrishikeshrt
Copy link
Owner Author

Functionality is added in the release v0.8.0.

Only one item from TODO remains, adding test-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release of stable version 1.0.0
Development

No branches or pull requests
1 participant
@hrishikeshrt