Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go dep #21338

Merged
merged 1 commit into from
Dec 20, 2024
Merged

bump go dep #21338

merged 1 commit into from
Dec 20, 2024

Conversation

wy65701436
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436
bump go dep
ae40102 
Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 requested a review from a team as a code owner December 19, 2024 09:53
@wy65701436 wy65701436 assigned chlins and unassigned AllForNothing and MinerYang Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.12.0@7d7a415). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21338    /-   ##
=================================================
  Coverage                  ?   66.08%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114656           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75767           
  Misses                    ?    34742           
  Partials                  ?     4147
Flag Coverage Δ
unittests 66.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

chlins
chlins approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 80219b7 into goharbor:release-2.12.0 Dec 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@stonezdj stonezdj stonezdj approved these changes

Assignees

@stonezdj stonezdj

@chlins chlins

Labels
release-note/update Update or Fix target/2.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wy65701436 @stonezdj @chlins @AllForNothing @MinerYang