Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Overflow in Interrogation Services Page #21043

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Overflow in Interrogation Services Page #21043

wants to merge 4 commits into from

Conversation

bupd
Copy link
Member

@bupd bupd commented Oct 14, 2024 •
edited
Loading

Summary

  • Fixes overflow in Interrogation Services -> Vulnerability Section.
  • The issue has been successfully resolved for screen resolutions from 1280x720 and higher.

Before Fix

on screen 1280x720
before vuln ui fix

After Fix

on screen 1280x720
fix ui 21043

Issue being fixed

Fixes #20818

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner October 14, 2024 17:40
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.28%. Comparing base (c8c11b4) to head (cce46d2).
Report is 338 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21043       /-   ##
==========================================
  Coverage   45.36%   46.28%    0.92%     
==========================================
  Files         244      247        3     
  Lines       13333    13863      530     
  Branches     2719     2867      148     
==========================================
  Hits         6049     6417      368     
- Misses       6983     7110      127     
- Partials      301      336       35
Flag Coverage Δ
unittests 46.28% <ø> ( 0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@Vad1mo Vad1mo self-requested a review October 15, 2024 12:16
Vad1mo
Vad1mo requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are already on it @bupd

having a fully vertical alignment (instead of a mix between both) is probably a better option.

Take a look 👇 what do you think?
376339491-628a4a3e-6837-41a0-858b-5b541e12c87c

@Vad1mo Vad1mo added the release-note/update Update or Fix label Oct 15, 2024
@bupd bupd force-pushed the vulnerability-ui-fix branch 2 times, most recently from 7e586cb to 1e2a9c8 Compare October 16, 2024 13:34
@Vad1mo
Copy link
Member

Vad1mo commented Oct 17, 2024

@bupd can you add yet another screenshot

@bupd
Copy link
Member Author

bupd commented Oct 17, 2024

Sure, @Vad1mo

Screenshot

fix ui 21043

bupd added 2 commits October 17, 2024 23:57
@bupd
fix overflow in interrogation services vuln page
e2dd2d0 
Signed-off-by: bupd <[email protected]>
@bupd
add space between items in vuln page
6f4796a 
* adds padding in between scan now and results of the scan

Signed-off-by: bupd <[email protected]>
@bupd bupd force-pushed the vulnerability-ui-fix branch from 1e2a9c8 to 6f4796a Compare October 17, 2024 18:27
@Vad1mo Vad1mo added the target/2.13.0 issues that are targeting v2.13.0 label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@Vad1mo Vad1mo

@chlins chlins

@MinerYang MinerYang

@xuelichao xuelichao

Labels
area/ui release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop scan all UI issue
6 participants
@bupd @Vad1mo @wy65701436 @chlins @MinerYang @xuelichao