Prepared users endpoint for pagination #3861 #3862
Conversation
There was a problem hiding this comment.
Thank you for the contribution, @sahilpatel342.
I have reviewed the changes and added a few comments.
Ps.
Updated existing tests and added new tests to verify pagination functionality.
This part from the description does not seem to be fitting 🤔
| @@ -352,7 352,17 @@ export class AdminController { | |||
| @Get('user') | |||
| @HasPermission(permissions.accessAdminControl) | |||
| @UseGuards(AuthGuard('jwt'), HasPermissionGuard) | |||
| public async getUsers(): Promise<AdminUsers> { | |||
| return this.adminService.getUsers(); | |||
| public async getUsers( | |||
There was a problem hiding this comment.
Just skip and take, you can remove the params for sorting.
| @@ -427,8 427,17 @@ export class AdminService { | |||
| }; | |||
| } | |||
|
|
|||
| public async getUsers(): Promise<AdminUsers> { | |||
| return { users: await this.getUsersWithAnalytics() }; | |||
| public async getUsers({ skip, take, sortColumn, sortDirection }: { | |||
There was a problem hiding this comment.
Just skip and take, you can remove the params for sorting.
| sortColumn?: string; | ||
| sortDirection?: Prisma.SortOrder; | ||
| }): Promise<AdminUsers> { | ||
| return this.userRepository.find({ |
There was a problem hiding this comment.
Still use return { users: await this.getUsersWithAnalytics() };, but pass skip, take and integrate them in the query.
|
Hey @sahilpatel342 Have you had a chance to check and implement the feedback from the code review? Let me know if you need anything! |
This change prepares the users endpoint for pagination #3861
Description:
• Implemented pagination support for the GET /api/v1/admin/user endpoint.
• Added skip, take, sortColumn, and sortDirection query parameters to control pagination and sorting.
• Modified service and repository logic to handle new parameters.
• Updated existing tests and added new tests to verify pagination functionality.
Code Changes:
• Updated controller to accept new query parameters.
• Adjusted service method to handle pagination and sorting.