Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11645] Control FreeMarker template access #8164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sikeoka
Copy link
Contributor

@sikeoka sikeoka commented Dec 24, 2024

GEOS-11645 Powered by Pull Request Badge

This PR adds an allow list and block list that controls what classes can be accessed in FreeMarker templates and also limits WMS GetFeatureInfo templates to only access getter methods by default. The documentation was updated with new system properties to control these features.

This PR will most likely require manual backporting.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@sikeoka sikeoka force-pushed the GEOS-11645 branch 5 times, most recently from 1b6d93d to 696cb46 Compare December 24, 2024 21:01
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants