Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant words in comment #4891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove redundant words in comment #4891

wants to merge 1 commit into from

Conversation

longxiangqiao
Copy link

@longxiangqiao longxiangqiao commented Nov 5, 2024 •
edited
Loading

Changes

remove redundant words in comment to make the comment more clearly

Reason

The words in the comment were repeated, removing them made the comment smoother and easier to read.

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (1320786) to head (9555641).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4891    /-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         251      251           
  Lines       28061    28061           
=======================================
  Hits        23597    23597           
  Misses       4464     4464
Flag Coverage Δ
5.10-c5n.metal 84.66% <ø> (ø)
5.10-m5n.metal 84.64% <ø> (-0.01%) ⬇️
5.10-m6a.metal 83.95% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.77% <ø> (ø)
5.10-m6i.metal 84.64% <ø> ( <0.01%) ⬆️
5.10-m7g.metal 80.77% <ø> (ø)
6.1-c5n.metal 84.66% <ø> (ø)
6.1-m5n.metal 84.64% <ø> (ø)
6.1-m6a.metal 83.95% <ø> (ø)
6.1-m6g.metal 80.77% <ø> (ø)
6.1-m6i.metal 84.64% <ø> (ø)
6.1-m7g.metal 80.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@longxiangqiao
Copy link
Author

Thanks!

If anything need I to do, Please feel free to tell me.

@pb8o
Copy link
Contributor

pb8o commented Nov 7, 2024

Thanks!

If anything need I to do, Please feel free to tell me.

Hi @longxiangqiao, I see our style checks didn't pass. You just need to add some text to the commit body. If you want to run our style checks on your end, you can do it by running ./tools/devtool checkstyle.

Thanks!

@longxiangqiao
Copy link
Author

Thanks!
If anything need I to do, Please feel free to tell me.

Hi @longxiangqiao, I see our style checks didn't pass. You just need to add some text to the commit body. If you want to run our style checks on your end, you can do it by running ./tools/devtool checkstyle.

Thanks!

Thanks for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pb8o pb8o pb8o approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longxiangqiao @pb8o