Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiler errors for main and tests #351

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix compiler errors for main and tests #351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift click to select a range
7b0f284
fix compile for main
byrnedj Nov 8, 2024
58c839d
add in dependencies
byrnedj Nov 20, 2024
47b0657
add to docker containers
byrnedj Nov 20, 2024
4b6b02d
actual dev libraries for xxhash
byrnedj Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add in dependencies
  • Loading branch information
@byrnedj
byrnedj committed Nov 20, 2024
commit 58c839dbe6f718b02ec5505a7677456c7b6af848
10 changes: 9 additions & 1 deletion contrib/build-package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 59,7 @@ options:
NAME: the dependency to build supported values are:
zstd
googlelog, googleflags, googletest,
fmt, sparsemap,
fmt, sparsemap, fastfloat,
folly, fizz, wangle, mvfst, fbthrift,
cachelib

Expand Down Expand Up @@ -195,6 195,14 @@ case "$1" in
external_git_clone=yes
;;

fastfloat)
NAME=fastfloat
REPO=https://github.com/fastfloat/fast_float.git
REPODIR=cachelib/external/$NAME
SRCDIR=$REPODIR
external_git_clone=yes
;;

folly)
NAME=folly
SRCDIR=cachelib/external/$NAME
Expand Down
2 changes: 1 addition & 1 deletion contrib/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 95,7 @@ build_arch()

build_dependencies()
{
for pkg in zstd googleflags googlelog googletest sparsemap fmt folly fizz wangle mvfst fbthrift ;
for pkg in zstd googleflags googlelog googletest sparsemap fmt fastfloat folly fizz wangle mvfst fbthrift ;
do
# shellcheck disable=SC2086
./contrib/build-package.sh $pass_params "$pkg" \
Expand Down
1 change: 1 addition & 0 deletions contrib/prerequisites-centos9.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 35,7 @@ sudo dnf install -y \
gtest-devel \
libsodium-static \
libdwarf-static \
xxhash \
numactl-devel


Expand Down
1 change: 1 addition & 0 deletions contrib/prerequisites-ubuntu18.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 41,7 @@ sudo apt-get install -y \
libdwarf-dev \
libsodium-dev \
libaio-dev \
xxhash \
libnuma-dev

# NOTE:
Expand Down
Loading