Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming to Nixpkgs #68

Closed
CutestNekoAqua opened this issue Sep 1, 2023 · 1 comment
Closed

Upstreaming to Nixpkgs #68

CutestNekoAqua opened this issue Sep 1, 2023 · 1 comment

Comments

@CutestNekoAqua
Copy link

Hi, can / do we want to upstream this to nixpkgs?

@ezKEa
Copy link
Owner

ezKEa commented Sep 1, 2023

Hi. I've gotten this question a few times, so now is probably a good time to state why I've refrained from upstreaming these modules and packages into nixpkgs:

  1. Merging into nixpkgs would make the speed at which I can make changes and update the packages significantly slower by virtue of the review process. Thus far I've been able to keep the launcher packages up to date within at least 1 day of updates being released (usually on the same day). In fact, I've built a non-trivial amount of CI infrastructure in this repo for this specifically.
  2. I don't want to bring any unneeded attention to the bypasses the launchers use, at the request of the launcher and patch developers. Even though GI now works without a patch, and anime-game-launcher could arguably be merged into Nixpkgs without much problem, this could change at any time if the game developers decide they want to finally switch to Tencent's AntiCheatExpert (as HI3 did). In this situation, the AAGL launcher and HI3/HSR patch would likely be updated to allow us to keep playing, but the launcher's presence in nixpkgs would essentially be advertising the bypass. I want to avoid this.

For these reasons, I don't plan to ever upstream this repo into nixpkgs. Thank you for understanding.

@ezKEa ezKEa closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
@LudovicoPiero LudovicoPiero pinned this issue Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants