WRQ-2288: Implement large screen mode #3235
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3235 /- ##
===========================================
Coverage 82.41% 82.62% 0.21%
===========================================
Files 156 156
Lines 7209 7285 76
Branches 1907 1926 19
===========================================
Hits 8631 6019 78
Misses 997 995 -2
Partials 271 271 ☔ View full report in Codecov by Sentry. |
|
Please check the missed checkbox in the description. |
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
There is a requirement for large screen mode(before large text) for a11y.
Since the purpose is to increase the screen magnification, the name large screen mode was used.
Resolution
When you pass the screenScale prop to resolutionDecorator, the base font size is calculated using that value.
Additional Considerations
Links
WRQ-2288
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])