Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic named variables in coordinates module #656

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Use generic named variables in coordinates module #656

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift click to select a range
93aaba7
this commit addresses #650
TONYOG12 Jan 30, 2024
caeae12
fix failed tests on quality ci
TONYOG12 Jan 30, 2024
7a99950
Update differential.py
TONYOG12 Jan 30, 2024
2647f31
fix failing tests
TONYOG12 Jan 30, 2024
54c7414
fix test conversions.py errors
TONYOG12 Jan 30, 2024
233a8d2
updates to adhere to pep8
TONYOG12 Jan 30, 2024
21e776c
address pep8 issues
TONYOG12 Jan 30, 2024
f3ef3f3
remove _velocities_provided and code duplication
TONYOG12 Jan 31, 2024
e6f0a7a
Update utils.py
TONYOG12 Jan 31, 2024
8a9906c
explicit typing for calculate_coordinates function
TONYOG12 Jan 31, 2024
01e5018
Update utils.py
TONYOG12 Jan 31, 2024
a88d365
Breaking Change
TONYOG12 Apr 27, 2024
164616f
move __str__, __repr__, __getitem__, position and system into the ba…
TONYOG12 May 20, 2024
35efca6
Update differential.py
TONYOG12 May 20, 2024
49ca159
Merge branch 'main' into streamline-the-coordinates-module
TONYOG12 May 29, 2024
b6d8e58
update timelike component of 4-v
TONYOG12 Jun 17, 2024
abfd6f6
Update differential.py
TONYOG12 Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
explicit typing for calculate_coordinates function
  • Loading branch information
@TONYOG12
TONYOG12 committed Jan 31, 2024
commit 8a9906ce220d94d298e7a5864228924bd067f5bc
7 changes: 6 additions & 1 deletion src/einsteinpy/coordinates/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 1,17 @@
from typing import Tuple

import numpy as np
from numba import float64, jit

from einsteinpy import constant
from einsteinpy.ijit import jit

_c = constant.c.value


def calculate_coordinates(r, th, p, alpha):
def calculate_coordinates(
r: float64, th: float64, p: float64, alpha: float64
) -> Tuple[float64, float64, float64, float64]:
xa = np.sqrt(r**2 alpha**2)
sin_norm = xa * np.sin(th)
e0 = sin_norm * np.cos(p)
Expand Down