feat: add trigonometric functions from postgres #7556
81
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.postgresql.org/docs/current/functions-math.html#FUNCTIONS-MATH-TRIG-TABLE
Took this: #5608 as example for current PR.
Need assistance:
Are there special error codes? For reverse functions there is domain restriction -1 <= x <= 1, idk if postgres returns special error for this. https://www.postgresql.org/docs/current/errcodes-appendix.html
Need tests. I can't do that because I afraid building and bootstrapping edgedb will take for me too much time, so I wouldn't able to run tests anyway.