Fix unit tests #13
Fix unit tests #13
Conversation
Added karma, chrome headless
package.json
Outdated
| @@ -43,5 44,14 @@ | |||
| "gulp-rename": "^1.2.2", | |||
| "mocha": "^3.0.1", | |||
| "run-sequence": "^1.2.2" | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Do we need to get rid of "chai" and "mocha" deps? Do the "karma-*" deps cover those?
There was a problem hiding this comment.
I just tested it, we can get rid of mocha. But chai and sinon are not covered by karma-*
| metric.sendToAnalytics('category_name', 'metric_name', 1234567890); | ||
| assert(spy.calledWith('send', 'timing', 'category_name', 'metric_name', 1234567890)); |
There was a problem hiding this comment.
These are testing that the GA api call is made, not that the entries are properly recorded in the PerformanceObserver. Can we keep the tests as is? Think that means removing sinon....?
There was a problem hiding this comment.
I tried leaving it as it was. However, when I first ran the tests they always failed. They were sending the wrong payload, metric.name was always google-analytics.com/analytics.js (or some variation of the GA script address).
The tests were previously more like integration tests and covered part of the internals of GA, which I'm not really sure is necessary. Since GA is a 'soft' peer dependency, as long as GA behaves then we shouldn't care except that we call the interface correctly.
Fixes #12
Switched to karma chrome headless sinon