-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtests subcommand #2952
base: master
Are you sure you want to change the base?
Add runtests subcommand #2952
Conversation
✅ PR OK, no changes in deprecations or warnings Total deprecations: 8 Total warnings: 0 Build statistics: statistics (-before, after)
-executable size=5293368 bin/dub
-rough build time=62s
executable size=5364928 bin/dub
rough build time=63s Full build output
|
Ideally these two would be merged together by looking for the json/sdl comment at start of file.
|
Although not impossible, only the minimum necessary functions have been implemented in this PR. Here is a list of others that I can think of that would be nice to have but have not yet been implemented:
If you can think of any very important enhancements, glitches, or future enhancements that might require breaking changes, please let me know. |
Support directory based dub projects. A directive to pick the directory by default on where the tests are instead of |
If you are talking about test cases, they are already implemented.
It is difficult to detect with certainty which directory contains test cases. |
No, I'm talking about
I didn't suggest automatic detection. I suggested a directive in your dub file to specify the directory to use. |
More information, please. Are you saying that you want to recognize the directory as being for the dub project without the dub.sdl?
I see. However, I considered this but decided not to include it in this PR. I believe that adding dub project configuration directives with a higher priority than the default but lower than command line arguments can be added in a future update, not this time. |
Below the tests directory, below that is either files that you're running. I would like it to also support dub projects at that level. It could be a misunderstanding on my part, but that changelog doesn't imply it. |
When you run |
First thing that comes to mind: We already have a special configuration for unittest, why not do that for integration tests ? Why a special command ? |
The idea of having a special configuration selected when running runtests subcommand might be a good one. By having a directive to replace |
As with many official tools, projects often require integration testing for CI/CD. In such cases, it is useful to run integration tests in a unified format.
The runtests subcommand I added is similar to
test/run-unittest.sh
ortest/run-unittest.d
so integration tests of dub projects can be run dub itself.To test dub, run the following command: