Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update path module to [email protected] #2821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update path module to [email protected] #2821

wants to merge 2 commits into from

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jan 19, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 8

Total warnings: 0

Build statistics:

 statistics (-before,  after)
-executable size=5297464 bin/dub
 executable size=5277208 bin/dub
 rough build time=63s
Full build output 
DUB version 1.38.0, built on Jul  4 2024
LDC - the LLVM D compiler (1.39.0):
  based on DMD v2.109.1 and LLVM 18.1.6
  built with LDC - the LLVM D compiler (1.39.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.39.0/x64/ldc2-1.39.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.39.0-beta.1 commit.21.g2d9f8b00: building configuration [application]
source/dub/internal/dyaml/composer.d(210,43): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/composer.d(232,43): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/composer.d(336,43): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(196,5): Deprecation: cannot access overlapped field `Event.explicitDocument` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(214,5): Deprecation: cannot access overlapped field `Event.explicitDocument` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(241,5): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(148,5): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(148,5): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
     Linking dub
STAT:statistics (-before,  after)
STAT:executable size=5277208 bin/dub
STAT:rough build time=63s

@Geod24 Geod24 mentioned this pull request Jan 19, 2024
Merged
@Geod24 Geod24 force-pushed the upgrade-path branch 2 times, most recently from 21620c6 to 5659959 Compare March 8, 2024 16:15
@Geod24 Geod24 mentioned this pull request Jun 18, 2024
Closed
@Geod24 Geod24 changed the title Update path module to [email protected] Update path module to [email protected] Jun 25, 2024
@Geod24
Disable -preview=dip1000 in CI
3924e76 
The warnings are now issued regardless of whether DIP1000 is used or not,
this just turns them into errors.
@Geod24
Update path module to [email protected]
26558a8
@Geod24
Copy link
Member Author

Geod24 commented Sep 25, 2024 

16 deprecation warnings omitted, use `-verrors=0` to show all
     Linking dub-test-library
 : fatal error LNK1318: Unexpected PDB error; OK (0) ''

Error: linker exited with status 1318
       C:\Program Files (x[86](https://github.com/dlang/dub/actions/runs/11024681696/job/30618263676?pr=2821#step:7:87))\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\link.exe /NOLOGO "C:\Users\runneradmin\AppData\Local\dub\cache\dub\~master\build\dub-test-library-unittest-bHzpISJ3I5gwpabjIG5Npw\dub-test-library.obj" /OUT:"C:\Users\runneradmin\AppData\Local\dub\cache\dub\~master\build\dub-test-library-unittest-bHzpISJ3I5gwpabjIG5Npw\dub-test-library.exe"  /DEFAULTLIB:phobos64 /DEBUG  /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x64" legacy_stdio_definitions.lib /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\Lib\10.0.22621.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\um\x64"
Error dmd failed with exit code 1.

That looks like fun.

@Geod24
Copy link
Member Author

Geod24 commented Sep 25, 2024

Ubuntu: 228/234 tests were successed. (nice typo)

[INFO] Running /home/runner/work/dub/dub/test/ddox.sh...
    Starting Performing "ddox" build using dmd for x86_64.
    Building ddox-project ~master [library]
             ddox is not present, getting and storing it user wide
    Fetching ddox 0.16.23
     Warning Sub package vibe-d:utils, referenced by vibe-d:web dub.package_.Package must be referenced using the path to its base package
Error Dependency from vibe-d:web to vibe-d:utils uses wrong path: /home/runner/.dub/packages/vibe-d/0.10.0/vibe-d/web/../ vs. /home/runner/.dub/packages/vibe-d/0.10.0/vibe-d/
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:11 command failed
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:11 command failed
[ERROR] Script failure.

[INFO] Running /home/runner/work/dub/dub/test/4-describe-data-2-dmd.sh...
     Warning 
     Warning ## Warning for package describe-project ##
     Warning 
     Warning The following compiler flags have been specified in the package description
     Warning file. They are handled by DUB and direct use in packages is discouraged.
     Warning Alternatively, you can set the DFLAGS environment variable to pass custom flags
     Warning to the compiler, or use one of the suggestions below:
     Warning 
     Warning releaseMode: Call DUB with --build=release
     Warning debugInfo: Call DUB with --build=debug
     Warning 
Not expecting escaped paths
1c1
< /home/runner/work/dub/dub/test/describe-project/src/dummy.d --some-dflag --another-dflag -L--some-lflag -L--another-lflag -L-lsomelib -L-lanotherlib /home/runner/work/dub/dub/test/describe-dependency-3/libdescribe-dependency-3.a /home/runner/work/dub/dub/test/describe-project/some.a /home/runner/work/dub/dub/test/describe-dependency-1/dep.a /home/runner/work/dub/dub/test/describe-project/src/dummy.d /home/runner/work/dub/dub/test/describe-dependency-1/source/dummy.d -version=someVerIdent -version=anotherVerIdent -version=Have_describe_dependency_3 -debug=someDebugVerIdent -debug=anotherDebugVerIdent -I/home/runner/work/dub/dub/test/describe-project/src/ -I/home/runner/work/dub/dub/test/describe-dependency-1/source/ -I/home/runner/work/dub/dub/test/describe-dependency-2/some-path/ -I/home/runner/work/dub/dub/test/describe-dependency-3/dep3-source/ -J/home/runner/work/dub/dub/test/describe-project/views/ -J/home/runner/work/dub/dub/test/describe-dependency-2/some-extra-string-import-path/ -J/home/runner/work/dub/dub/test/describe-dependency-3/dep3-string-import-path/ /home/runner/work/dub/dub/test/describe-dependency-2/some-path/dummy.d -debug -g -gx -wi
---
> /home/runner/work/dub/dub/test/describe-project/src/dummy.d --some-dflag --another-dflag -L--some-lflag -L--another-lflag -L-lsomelib -L-lanotherlib /home/runner/work/dub/dub/test/describe-dependency-3/libdescribe-dependency-3.a /home/runner/work/dub/dub/test/describe-project/some.a /home/runner/work/dub/dub/test/describe-dependency-1/dep.a /home/runner/work/dub/dub/test/describe-project/src/dummy.d /home/runner/work/dub/dub/test/describe-project/../describe-dependency-1/source/dummy.d -version=someVerIdent -version=anotherVerIdent -version=Have_describe_dependency_3 -debug=someDebugVerIdent -debug=anotherDebugVerIdent -I/home/runner/work/dub/dub/test/describe-project/src/ -I/home/runner/work/dub/dub/test/describe-project/../describe-dependency-1/source/ -I/home/runner/work/dub/dub/test/describe-project/../describe-dependency-2/some-path/ -I/home/runner/work/dub/dub/test/describe-project/../describe-dependency-3/dep3-source/ -J/home/runner/work/dub/dub/test/describe-project/views/ -J/home/runner/work/dub/dub/test/describe-project/../describe-dependency-2/some-extra-string-import-path/ -J/home/runner/work/dub/dub/test/describe-project/../describe-dependency-3/dep3-string-import-path/ /home/runner/work/dub/dub/test/describe-dependency-2/some-path/dummy.d -debug -g -gx -wi
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:86 The project data did not match the expected output!
[ERROR] Script failure.

==> Missing normalization

[INFO] Running /home/runner/work/dub/dub/test/issue103-single-file-package.sh...
    Starting Performing "debug" build using dmd for x86_64.
    Building single-file-test ~master: building configuration [application]
     Linking single-file-test
     Running single-file-test 
Hello, World!
Error: module `hello` from file issue103-single-file-package.d conflicts with another module hello from file ./issue103-single-file-package.d
Error dmd failed with exit code 1.
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:12 command failed

[INFO] Running /home/runner/work/dub/dub/test/issue2840-build-collision.sh...
~/work/dub/dub/test/issue2840-build-collision ~/work/dub/dub
'build.d' -> 'nested/build.d'
Error: module `build` from file build.d conflicts with another module build from file ./build.d
Error dmd failed with exit code 1.
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:9 command failed
[ERROR] Script failure.
[INFO] Running /home/runner/work/dub/dub/test/issue877-auto-fetch-package-on-run.sh...
  /home/runner/work/dub/dub/bin/dub remove 'gitcompatibledubpackage@*'
    Removing gitcompatibledubpackage (in /home/runner/.dub/packages/gitcompatibledubpackage/1.0.2/gitcompatibledubpackage/)
     Removed gitcompatibledubpackage 1.0.2
  echo y
  /home/runner/work/dub/dub/bin/dub run gitcompatibledubpackage
  grep 'Hello DUB'
Error: module `hello` from file ../../../.dub/packages/gitcompatibledubpackage/1.0.4/gitcompatibledubpackage/hello.d conflicts with another module hello from file ../../../.dub/packages/gitcompatibledubpackage/1.0.4/gitcompatibledubpackage/./hello.d
Error dmd failed with exit code 1.
[ERROR] Script failure.

At a glance, they all look related to normalization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Geod24