Skip to content

Commit

Permalink
Build: Remove package-lock.json, add it to .gitignore
Browse files Browse the repository at this point in the history
npm 5, even the version included in the latest Node.js 8.5.0 re-generates
`package-lock.json` on each install. And when it does on a system that doesn't
support all the optional dependencies that are supported on the OS where the
lockfile was generated, it removes those optional deps from the lockfile.

The effect is that everyone firing `npm install` on our repo on any OS other
than macOS will immediately get a dirty state of the repo as the `fsevents`
dependency subtree gets removed from `package-lock.json`. That's a really bad
experience.

This commit removes package-lock.json from the repository and adds it to
.gitignore. We'll start committing the file again once the issue is resolved
on npm's part.

Fixes jquerygh-3792
  • Loading branch information
mgol committed Sep 25, 2017
1 parent 81be78e commit 7037fac
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5,624 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 8,7 @@
.bower.json
.sizecache.json
yarn.lock
package-lock.json

npm-debug.log*

Expand Down
Loading

0 comments on commit 7037fac

Please sign in to comment.