Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic bash completion #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianlshaw
Copy link

Made a bash completion script a while ago and donating it here :-)

@derrod
Copy link
Owner

derrod commented Oct 5, 2020

Thanks. I'll check how to make sure this also works for installations into the user directory and then merge it with minor changes.

@derrod
Copy link
Owner

derrod commented Oct 31, 2020

Alright coming back to this I got to say that I'm not entirely happy since this will probably not work when installing via pip, probably requires sudo when installing, and also installs the file regardless of whether or not bash is even used. I might go down the same route as pip itself (see pip docs) and only keep this for the deb files (since bash is still default for ubuntu/debian).

@ghost
Copy link

ghost commented Dec 3, 2020

I'd be in favor of including all (future) shell completion regardless of which shell is being used. It's 1 tiny file per shell that'd allow me to get the full experience if I'd change to or try a different shell.

@adityaruplaha
Copy link

What is the status on this? As a user I would really appreciate if this gets looked into and merged.

@sebtoun
Copy link

sebtoun commented Oct 6, 2021

Having all completion files packaged with the program and have a dedicated sub-command to the program CLI that installs the completion for the current shell could be an alternative, but requires more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants