-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygsp Laplacian calculation #8
Comments
Thanks for your interest and kind words! Indeed, the class is named |
OK, got it. The parameter signature of the constructor has changed though. I'm assuming the new subdivisions argument can be calculated as 2n where n is the order of the Icosahedron? There are a few other minor updates required that I'll add to a PR. |
Right. That was done in epfl-lts2/pygsp@39a0665 to unify the parameters across the multiple discretizations of the sphere.
Correct. While We did actually update the required PyGSP version to fix a bunch of issues (#7). But those API changes got overlooked. Looking forward to the PR. Many thanks @phil-hawkins! |
The project runs now, however it seems like the performance isn't where it should be, at least with the default config with respect to the results in the paper. I'm not sure if this related to the config, my changes or something earlier. This is the result form the final epoch run with default config: Do you have any ideas on this @mdeff? |
Thank you for for the great research on spherical graphs.
In https://github.com/deepsphere/deepsphere-pytorch/blob/master/deepsphere/utils/laplacian_funcs.py
the code attempts to import the class SphereIcosahedron and later call the method compute_laplacian on it.
I have installed the version of pygsp as per the readme instructions:
pip install git https://github.com/epfl-lts2/pygsp.git@39a0665f637191152605911cf209fc16a36e5ae9#egg=PyGSP
However this version has no class SphereIcosahedron
The text was updated successfully, but these errors were encountered: