Improve error message for incorrect columns order in meta information #11393
Conversation
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 13 files ±0 13 suites ±0 3h 6m 59s ⏱️ 3m 11s Results for commit 6447bf1. ± Comparison against base commit e71d436. ♻️ This comment has been updated with latest results. |
dbalabka
force-pushed
the
patch-2
branch
2 times, most recently
from
66f237a
to
3e6bcc7
Compare
There was a problem hiding this comment.
Thanks @dbalabka. This looks really close -- just one small question below
dask/dataframe/utils.py
Outdated
| f"\nActual: { { c: str(t) for c, t in meta.dtypes.items() } }" | ||
| f"\nExpected: { { c: str(t) for c, t in actual.dtypes.items() } }" |
There was a problem hiding this comment.
Why include dtype info here and not just the order of the columns? Seems irrelevant for the error being raised
There was a problem hiding this comment.
Good question. I like to see the function's output types for sanity check purposes. Futhermore, I can copy and paste the entire dict into the meta parameter if needed.
Also, I probably don't understand the purpose of this exception. If we know the order of the columns, why not simply reorder the columns?
There was a problem hiding this comment.
@jrbourbeau, let's convert dict to list if you think it makes more sense.
There was a problem hiding this comment.
Yeah, let's do that. I think just listing the columns in order makes the most sense here.
pre-commit run --all-files