New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sizing issue when scrolling on issue detail with comments #31

Open

danjohnson95 opened this issue Jan 30, 2017 · 1 comment

Labels

bug

Milestone

Owner

danjohnson95 commented Jan 30, 2017

The issue detail header height can vary, so we can't set the height of the comment scroll div in CSS.

Instead, we'll need to detect the height in JS once we've injected the content, and then set the height accordingly afterwards.

danjohnson95 added the bug label

danjohnson95 added this to the 1.0.0 milestone

danjohnson95 self-assigned this

Owner Author

danjohnson95 commented Feb 3, 2017

Merged, but still need to add functionality for when window resized.

danjohnson95 removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment