Adding AccountController tests, tidying up some formatting issues

dancita · Mar 17, 2023 · 54c5af6 · 54c5af6
1 parent ff15b29
commit 54c5af6
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 5 deletions.
diff --git a/src/Controllers/AccountController.cs b/src/Controllers/AccountController.cs
@@ -16,7  16,6 @@ public AccountController(IManagementService managementService)
             _managementService = managementService;
         }
 
-
         [HttpGet]
         public async Task<ActionResult<IEnumerable<Account>>> GetAccounts()
         {

diff --git a/src/Services/IManagementService.cs b/src/Services/IManagementService.cs
@@ -1,5  1,4 @@
 using AccountManagementAPI.Models;
-using Microsoft.AspNetCore.Mvc;
 
 namespace AccountManagementAPI.Services
 {

diff --git a/src/Services/ManagementService.cs b/src/Services/ManagementService.cs
@@ -1,5  1,4 @@
 using AccountManagementAPI.Models;
-using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
 
 namespace AccountManagementAPI.Services

diff --git a/tests/AccountManagementAPITests/Controllers/AccountControllerTests.cs b/tests/AccountManagementAPITests/Controllers/AccountControllerTests.cs
@@ -146,5  146,64 @@ public async Task GetAccount_InvalidAccountId_ThrowsAccountManagementAPIExceptio
             // Assert
             ex.Message.ShouldBe("An error occured while trying to get an account by id : 5");
         }
 
         [Fact]
         public async Task ToggleAccountState_Successful_MustReturnNoContent()
         {
             // Arrange
             var testAccount = new Account()
             {
                 Id = 5,
                 AccountHolderName = "Test Account Holder",
                 IsActive = true
             };
             _managementService.Setup(x => x.GetAccount(5)).ReturnsAsync(testAccount);
             _managementService.Setup(x => x.ToggleAccountStatus(testAccount)).ReturnsAsync(new Account()
             {
                 Id = 5,
                 AccountHolderName = "Test Account Holder",
                 IsActive = false
             });
             var accountController = new AccountController(_managementService.Object);
 
             // Act
             var result = await accountController.ToggleAccountState(5);
 
             // Assert
             Assert.IsAssignableFrom<NoContentResult>(result);
         }
 
         [Fact]
         public async Task ToggleAccountState_InvalidId_ThrowsNotFoundException()
         {
             // Arrange
             var accountController = new AccountController(_managementService.Object);
 
             // Act
             var ex = await Assert.ThrowsAsync<NotFoundException>(() => accountController.ToggleAccountState(6));
 
             // Assert
             ex.Message.ShouldBe("Account wasn't found with id : 6");
         }
 
         [Fact]
         public async Task ToggleAccountState_ValidIdUnsuccessfulUpdate_ThrowsAccountManagementAPIException()
         {
             // Arrange
             var testAccount = new Account()
             {
                 Id = 5,
                 AccountHolderName = "Test Account Holder",
                 IsActive = true
             };
             _managementService.Setup(x => x.GetAccount(5)).ReturnsAsync(testAccount);
             var accountController = new AccountController(_managementService.Object);
 
             // Act
             var ex = await Assert.ThrowsAsync<AccountManagementAPIException>(() => accountController.ToggleAccountState(5));
 
             // Assert
             ex.Message.ShouldBe("An error occured while toggling the account status");
         }
     }
 }
diff --git a/tests/AccountManagementAPITests/Controllers/PhoneNumberControllerTests.cs b/tests/AccountManagementAPITests/Controllers/PhoneNumberControllerTests.cs
@@ -60,13  60,13 @@ public async Task GetPhoneNumbersByAccountId_NoAccountIdAssignedToPhoneNumber_Th
         [Fact]
         public async Task DeletePhoneNumber_ValidId_MustReturnNoContent()
         {
             // Arrange
             var phoneNumber = new PhoneNumber()
             {
                 AccountId = 1,
                 Id = 2,
                 Number = "555-4321"
             };
-            // Arrange
             _managementService.Setup(x => x.GetPhoneNumber(2)).ReturnsAsync(phoneNumber);
 
             _managementService.Setup(x => x.DeletePhoneNumber(phoneNumber)).ReturnsAsync(true);
@@ -83,6  83,7 @@ public async Task DeletePhoneNumber_ValidId_MustReturnNoContent()
         [Fact]
         public async Task DeletePhoneNumber_InvalidId_ThrowsNotFoundException()
         {
             // Arrange
             var phoneNumberController = new PhoneNumberController(_managementService.Object);
 
             // Act
@@ -95,13  96,13 @@ public async Task DeletePhoneNumber_InvalidId_ThrowsNotFoundException()
         [Fact]
         public async Task DeletePhoneNumber_UnsuccessfulDelete_ThrowsAccountManagementAPIException()
         {
             // Arrange
             var phoneNumber = new PhoneNumber()
             {
                 AccountId = 1,
                 Id = 2,
                 Number = "555-4321"
             };
-            // Arrange
             _managementService.Setup(x => x.GetPhoneNumber(2)).ReturnsAsync(phoneNumber);
 
             _managementService.Setup(x => x.DeletePhoneNumber(phoneNumber)).ReturnsAsync(false);
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 16,6 @@ public AccountController(IManagementService managementService) @@
                 _managementService = managementService;
             }
             [HttpGet]
             public async Task<ActionResult<IEnumerable<Account>>> GetAccounts()
             {
@@ Expand Down @@